Network
" - "Edits apply to RAM only. Save persists the device working configuration, NOT browser drafts. Refresh discards drafts. " + "
Edits apply to RAM only. Save persists the device working configuration, NOT browser drafts. Refresh discards drafts. " "Wi-Fi Load uses stored configuration only; missing or invalid storage leaves RAM unchanged. No Wi-Fi defaults/reset. " "Start/Stop also change RAM enabled-at-boot; Save persists that policy. Reconnect/Next do nothing while stopped. " "Next selects the next enabled profile in priority order, wrapping.
" - "Network changes may disconnect HTTPS, SSH and both browser terminals before acknowledgement. Accepted is NOT connected. " + "
Network changes may disconnect HTTPS, SSH and both browser terminals before acknowledgement. Accepted is NOT connected. " "Recover through STA/AP, UART0 or network-independent native USB serial. Navigation itself preserves terminals and writer lease.
" - "" - "" - "Wi-Fi working configuration
"
+ ""
+ ""
"
Wi-Fi working configuration
"
""
- ""
+ ""
""
""
- ""
+ ""
""
""
""
@@ -205,27 +210,27 @@ static const char s_index_html[] =
""
"
"
- ""
- "SSID maximum: 32 bytes, not characters. Text entry encodes UTF-8 once; hex preserves arbitrary bytes including zero. " + "
" + "SSID maximum: 32 bytes, not characters. Text entry encodes UTF-8 once; hex preserves arbitrary bytes including zero. " "Switching modes is lossless or refused. Password replacement requires 8–63 printable ASCII characters; blank never clears. " "AP always requires a PSK. STA clear requires disabled state. Transient passwords expire after 60 seconds and clear on submission or context change. " "NVS is unencrypted; replacement/clear is not secure flash erasure. JavaScript cannot securely zero strings.
" - "" - ""
+ "
"
+ ""
+ ""
+ ""
""
- ""
+ "
Wi-Fi connection
"
"
"
- "mDNS
STA-only responder. Expected announcement is not client-verified DNS. " + "
mDNS
STA-only responder. Expected announcement is not client-verified DNS. " "Suffix edits, Load and Defaults change RAM and request live reannouncement; queue failure can leave RAM changed. " "Offline edits are used on the next STA IP. mDNS Load may select deterministic MAC defaults. Save explicitly persists.
" - "" - "1–55 lowercase ASCII letters, digits or hyphens; no leading/trailing hyphen.
"
+ ""
+ "
"
- ""
- "1–55 lowercase ASCII letters, digits or hyphens; no leading/trailing hyphen.
"
""
""
""
"
After uncertainty, Check Result and Refresh. Never assume timeout or navigation cancels work; no automatic mutation retry.
After uncertainty, Check Result and Refresh. Never assume timeout or navigation cancels work; no automatic mutation retry.
Serial
Working UART1 configuration below is not a saved NVS snapshot. " "Navigation leaves both terminals connected and preserves the serial writer lease.
" "" @@ -264,9 +269,9 @@ static const char s_index_html[] = "Accounts
" "Role and deletion changes are saved immediately and revoke only the affected account's network sessions. The final administrator is protected. " "Self changes can immediately close all this account's web/SSH sessions, including browser serial/admin. A disconnect or 401 is NOT proof of success; re-login and inspect before retrying.
" - "" + "" "Select Refresh to read accounts.
" - ""
+ "
"
+ "Account selection / Edit account
"
"
"
""
""
- "
"
- "Authorized SSH public keys
Paste one OpenSSH Ed25519 or ECDSA P-256 public key (maximum 384 UTF-8 bytes). Public keys only; no private-key upload, export or SSH host management. Up to three keys per account.
" + "Authorized SSH public keys
Paste one OpenSSH Ed25519 or ECDSA P-256 public key (maximum 384 UTF-8 bytes). Public keys only; no private-key upload, export or SSH host management. Up to three keys per account.
" "" - "" + ""
""
- ""
+ "
"
""
"
"
- ""
+ "]*>.*?', '', html, flags=re.S)
+ fixture = re.sub(r']*>|]*>', '', fixture)
+ probe = r'''
+ const cases = [];
+ for (const width of [320, 600, 1200]) for (const view of ['serial-settings-content', 'account-settings', 'network-settings']) {
+ const frame = document.createElement('iframe'); frame.style.width = width + 'px'; frame.style.height = '900px';
+ cases.push(new Promise(resolve => {
+ frame.onload = () => {
+ const d = frame.contentDocument, win = frame.contentWindow;
+ d.getElementById('serial-settings').hidden = false;
+ for (const id of ['serial-settings-content', 'account-settings', 'network-settings']) d.getElementById(id).hidden = id !== view;
+ const section = d.getElementById(view);
+ section.querySelectorAll('[hidden]').forEach(n => n.hidden = false);
+ section.querySelectorAll('dl').forEach(dl => {
+ dl.textContent = '';
+ for (let i = 0; i < 8; i++) {
+ const dt = d.createElement('dt'), dd = d.createElement('dd');
+ dt.textContent = 'Password configured'; dd.textContent = 'SHA256:' + 'x'.repeat(96);
+ dl.append(dt, dd);
+ }
+ });
+ section.querySelectorAll('input:not([type=checkbox]),textarea').forEach(n => n.value = 'x'.repeat(96));
+ const errors = [];
+ for (const node of section.querySelectorAll('dl,input,select,textarea,.settings-edit,.serial-edit,.serial-actions')) {
+ const rect = node.getBoundingClientRect();
+ if (!rect.width) continue;
+ if (rect.left < 0 || rect.right > width + 1) errors.push('overflow:' + (node.id || node.className));
+ if (node.matches('dl') && node.scrollWidth > node.clientWidth + 1) errors.push('summary overflow');
+ if (node.matches('input[type=checkbox]') && rect.width > 30) errors.push('checkbox width');
+ if (node.matches('dl,.settings-edit,.serial-edit') && rect.width > 601) errors.push('max width');
+ }
+ // Measure glyph ranges, not the full-width grid cell or textContent.
+ // The normal-whitespace control proves the pair detects collapsing.
+ for (const dd of section.querySelectorAll('dl dd:first-of-type')) {
+ const original = dd.textContent;
+ const measureSSID = spaces => {
+ dd.textContent = 'SSID: ' + JSON.stringify('office' + ' '.repeat(spaces) + 'wifi');
+ const range = d.createRange();
+ range.setStart(dd.firstChild, 7); range.setEnd(dd.firstChild, dd.textContent.length - 1);
+ if (range.getClientRects().length !== 1) errors.push('SSID probe unexpectedly wrapped');
+ return range.getBoundingClientRect().width;
+ };
+ const single = measureSSID(1), double = measureSSID(2);
+ if (!(single > 0 && double > single + 1)) errors.push('consecutive SSID spaces collapsed');
+ dd.style.whiteSpace = 'normal';
+ if (Math.abs(measureSSID(2) - measureSSID(1)) > 0.1) errors.push('invalid whitespace control');
+ dd.style.removeProperty('white-space'); dd.textContent = original;
+ }
+ resolve({width, view, errors});
+ };
+ }));
+ frame.srcdoc = FIXTURE; document.body.append(frame);
+ }
+ Promise.all(cases).then(results => {
+ const out = document.createElement('pre'); out.id = 'layout-results'; out.textContent = JSON.stringify(results); document.body.append(out);
+ });
+ '''.replace('FIXTURE', json.dumps(fixture))
+ page = tmp / 'layout-probe.html'
+ page.write_text('')
+ result = subprocess.run([executable, '--headless', '--no-sandbox', '--disable-gpu',
+ '--no-first-run', '--disable-background-networking',
+ '--user-data-dir=' + str(tmp / 'chromium-profile'),
+ '--virtual-time-budget=3000', '--dump-dom', page.as_uri()],
+ capture_output=True, text=True, timeout=30)
+ assert result.returncode == 0, result.stderr
+ parsed = Document(result.stdout)
+ results = json.loads(parsed.ids['layout-results']['text'])
+ assert len(results) == 9
+ assert all(not case['errors'] for case in results), results
+ print('PASS Chromium layout: all three settings views at 320/600/1200px; bounded controls, summaries, inline checkboxes and rendered consecutive-space distinction (fixture data, not live app)')
\ No newline at end of file
diff --git a/tests/web_ui_session/network.cjs b/tests/web_ui_session/network.cjs
index 14d6c85..4277c02 100644
--- a/tests/web_ui_session/network.cjs
+++ b/tests/web_ui_session/network.cjs
@@ -73,6 +73,26 @@ module.exports = async ({test, browser, adminBrowser, tick, json, session, failu
}
assert.equal(posts(b).length, 0);
});
+ await test('Structured network rows retain every field, escape markup and clear/fence navigation', async () => {
+ const v = fixture(); v.wifi.ap.ssid = '![]()
';
+ const b = await open(v), summary = n(b, 'summary');
+ const rows = summary.children;
+ assert.equal(rows.length, 58);
+ rows.forEach((node, i) => { assert.equal(node.tagName, i % 2 ? 'DD' : 'DT'); assert.equal(node.children.length, 0); });
+ const values = Object.fromEntries(rows.filter((_, i) => i % 2 === 0).map((node, i) => [node.textContent, rows[i * 2 + 1].textContent]));
+ assert.equal(values['AP SSID'], 'SSID: ' + JSON.stringify(v.wifi.ap.ssid));
+ assert.equal(values['AP password configured'], 'true');
+ assert.equal(values['STA 3 password configured'], 'false');
+ assert.equal(values['AP clients'], '1'); assert.equal(values['Wi-Fi last error'], '0');
+ assert.equal(values['mDNS last error'], '0'); assert.equal(values['Expected announcement'], 'false');
+ assert.equal(values['DNS verification'], 'Not client-verified DNS.');
+ const d = deferred(); b.queues[path].push(d.promise); b.click('network-refresh'); await tick();
+ b.click('settings-accounts'); await tick(); assert.equal(summary.children.length, 0);
+ assert.ok(rows.every(node => node.parentNode === null));
+ d.resolve(json(v)); await tick(); assert.equal(summary.children.length, 0);
+ b.queues[path].push(json(fixture())); b.click('settings-network'); await tick();
+ assert.equal(summary.children.length, 58); assert.ok(!summary.textContent.includes(' {
const edits = [v => v.password = 'SECRET', v => v.wifi.password = 'SECRET', v => v.wifi.ap.password = 'SECRET', v => v.wifi.profiles[1].password = 'SECRET',
v => delete v.runtime.ip, v => v.wifi.generation = 0, v => v.mdns.generation = 4294967296, v => v.wifi.enabled_at_boot = 1,
@@ -272,7 +292,10 @@ module.exports = async ({test, browser, adminBrowser, tick, json, session, failu
if (state === 'stale') assert.match(n(b, 'operation-detail').textContent, /Generation stale.*No automatic retry/);
if (state === 'applied_not_queued') assert.match(n(b, 'operation-detail').textContent, /RAM changed.*queue failed.*NOT rolled back/);
if (state === 'loaded_defaults') assert.match(n(b, 'operation-detail').textContent, /mDNS Load.*defaults in RAM.*NVS unchanged/);
- assert.match(n(b, 'summary').textContent, /Runtime: error/); assert.match(n(b, 'summary').textContent, /last error 259/);
+ assert.match(n(b, 'summary').textContent, /Runtime: error/); for (const label of ['Wi-Fi last error', 'mDNS last error']) {
+ const rows = n(b, 'summary').children, index = rows.findIndex(node => node.tagName === 'DT' && node.textContent === label);
+ assert.ok(index >= 0); assert.equal(rows[index + 1].tagName, 'DD'); assert.equal(rows[index + 1].textContent, '259');
+ }
}
const b = await open(); b.queues[operation].push(reply(42,'accepted','stop')); b.queues[path].push(failure(503)); b.click('network-result'); await tick();
assert.match(n(b, 'operation-detail').textContent, /Accepted/); assert.match(n(b, 'detail').textContent, /stale/); assert.equal(n(b, 'edit').hidden, false); assert.ok(n(b, 'apply').disabled);
diff --git a/tests/web_ui_session/run.py b/tests/web_ui_session/run.py
index 585e706..9961263 100644
--- a/tests/web_ui_session/run.py
+++ b/tests/web_ui_session/run.py
@@ -10,6 +10,10 @@ import re
import shlex
import subprocess
import tempfile
+import sys
+
+sys.dont_write_bytecode = True
+from layout import check_layout, check_browser_layout
HERE = Path(__file__).resolve().parent
ROOT = HERE.parents[1]
@@ -90,6 +94,9 @@ esp_err_t httpd_resp_send(httpd_req_t *, const char *, ssize_t);
assert 'no private-key upload, export or SSH host management' in rendered['html']
for forbidden in ('localStorage', 'sessionStorage', 'document.cookie', 'console.log', 'innerHTML', 'Authorization', 'clipboard', 'pushState', 'replaceState'):
assert forbidden not in rendered['script'] + rendered['loader'], forbidden
+ check_layout(rendered['html'])
+ if os.environ.get('WEB_UI_CHROMIUM'):
+ check_browser_layout(rendered['html'], tmp, os.environ['WEB_UI_CHROMIUM'])
(tmp / 'rendered.json').write_text(json.dumps(rendered))
subprocess.run(['node', str(HERE / 'browser.cjs'), str(tmp / 'rendered.json')], check=True, timeout=30)
print('PASS C/HTML: all resource headers/failures, no-store app/document, exact loader CSP, safe fallback')
Create account / Change password
"
""
""
""
"
"
"12-64 printable ASCII characters; spaces are significant. Confirm every password. Save it before submitting, especially for your own account.
" "" - ""
- "
"
+ "One-time display, no retrieval. Copy and save now; this display and password fields expire after 60 seconds. Enter it in Confirm password.
" - ""
+ "
"
"One-time display, no retrieval. Copy and save now; this display and password fields expire after 60 seconds. Enter it in Confirm password.
" + "Secrets are cleared on submission and when leaving or changing this form. JavaScript cannot securely zero strings or browser-managed copies.
" "" "" @@ -307,6 +312,13 @@ static const char s_app_js[] = "(() => {\n" "'use strict';\n" "const element = (id) => document.getElementById(id);\n" + "function settingsRows(target, rows) {\n" + " target.textContent = '';\n" + " for (const [label, value] of rows) {\n" + " const dt = document.createElement('dt'), dd = document.createElement('dd');\n" + " dt.textContent = label; dd.textContent = value; target.appendChild(dt); target.appendChild(dd);\n" + " }\n" + "}\n" "const connectionStatus = element('connection-status');\n" "const roleStatus = element('role-status');\n" "const clientIdField = element('client-id');\n" @@ -491,7 +503,7 @@ static const char s_app_js[] = " if (!p || Object.keys(p).length !== 4 || p.username !== t.username || p.user_id !== t.user_id || p.auth_generation !== t.auth_generation) throw new Error('Stale key identity');\n" " if (!Array.isArray(p.keys) || p.keys.length > 3 || new Set(p.keys.map(k => k?.index)).size !== p.keys.length || !p.keys.every(k => k && Object.keys(k).length === 3 && Number.isInteger(k.index) && k.index >= 0 && k.index <= 2 && ['ssh-ed25519','ecdsa-sha2-nistp256'].includes(k.type) && typeof k.fingerprint === 'string' && /^SHA256:[A-Za-z0-9+/]{43}$/.test(k.fingerprint))) throw new Error('Invalid keys');\n" " accountKeys = p.keys; keysIdentity = identity;\n" - " element('account-keys-list').textContent = accountKeys.map(k => k.index + ': ' + k.type + ' ' + k.fingerprint).join('\\n');\n" + " settingsRows(element('account-keys-list'), accountKeys.map(k => [k.index + ': ', k.type + ' ' + k.fingerprint]));\n" " for (let i = 0; i < 3; ++i) { const o = element('key-option-' + i), key = accountKeys.find(k => k.index === i); o.value = String(i); o.textContent = key ? key.index + ': ' + key.fingerprint : ''; o.hidden = o.disabled = !key; }\n" " element('account-key-index').value = accountKeys.length ? String(accountKeys[0].index) : ''; element('account-keys-detail').textContent = t.username + ': ' + accountKeys.length + ' authorized keys. List refreshed.';\n" " } catch (error) { if (current()) { clearAccountKeys(); element('account-keys-detail').textContent = error.status === 409 || error.message === 'Stale key identity' ? 'Account identity stale. Refresh accounts and select the target again; no automatic retry.' : 'Keys unavailable or invalid. Refresh accounts or explicitly read keys again; no automatic retry.'; accountButtons(); } }\n" @@ -568,7 +580,7 @@ static const char s_app_js[] = " !payload.users.every(u => u && Object.keys(u).length === 4 && typeof u.username === 'string' && /^[a-z][a-z0-9_-]{0,15}$/.test(u.username) && validId(u.user_id) && validId(u.auth_generation) && ['user','admin'].includes(u.role)) ||\n" " new Set(payload.users.map(u => u.username)).size !== payload.users.length) throw new Error('Invalid account list');\n" " clearAccountSecret(); accounts = payload.users;\n" - " element('accounts-list').textContent = accounts.map(u => u.username + ' — ' + u.role + (u.username === sessionIdentity.username ? ' (you)' : '')).join('\\n');\n" + " settingsRows(element('accounts-list'), accounts.map(u => [u.username, u.role + (u.username === sessionIdentity.username ? ' (you)' : '')]));\n" " for (let i = 0; i < 8; ++i) { const option = element('account-option-' + i); option.textContent = accounts[i]?.username || ''; option.hidden = option.disabled = !accounts[i]; }\n" " const index = Math.max(0, accounts.findIndex(t => t.username === previous?.username && t.user_id === previous?.user_id));\n" " element('account-target').value = String(index); element('account-role').value = accounts[index]?.role || 'user';\n" @@ -779,8 +791,14 @@ static const char s_app_js[] = " if (status !== 200 || !validateNetwork(payload)) throw new Error('Invalid network snapshot');\n" " networkSnapshot = payload; networkFresh = true;\n" " const w = payload.wifi, r = payload.runtime, m = payload.mdns;\n" - " net('summary').textContent = 'Wi-Fi generation ' + w.generation + '; boot enabled: ' + w.enabled_at_boot + '\\nAP ' + w.ap.policy + ', channel ' + w.ap.channel + ', ' + networkSSIDSummary(w.ap.ssid) + ', password configured: ' + w.ap.password_configured + '\\n' +\n" - " w.profiles.map(p => 'STA ' + p.index + ': enabled ' + p.enabled + ', priority ' + p.priority + ', ' + p.security + ', ' + networkSSIDSummary(p.ssid) + ', password configured: ' + p.password_configured).join('\\n') + '\\nRuntime: ' + r.state + ', started ' + r.started + ', active profile ' + r.active_profile + ', IP ' + (r.ip || 'none') + ', AP running ' + r.ap_running + ', AP clients ' + r.ap_clients + ', last error ' + r.last_error + '\\nmDNS generation ' + m.generation + ': ' + m.hostname + '.local; expected announcement ' + m.announced + ', last error ' + m.last_error + '. Not client-verified DNS.';\n" + " settingsRows(net('summary'), [\n" + " ['Wi-Fi generation', w.generation], ['Enabled at boot', w.enabled_at_boot],\n" + " ['AP policy / channel', w.ap.policy + ' / ' + w.ap.channel], ['AP SSID', networkSSIDSummary(w.ap.ssid)], ['AP password configured', w.ap.password_configured],\n" + " ...w.profiles.flatMap(p => [['STA ' + p.index, 'enabled ' + p.enabled + ', priority ' + p.priority + ', ' + p.security], ['STA ' + p.index + ' SSID', networkSSIDSummary(p.ssid)], ['STA ' + p.index + ' password configured', p.password_configured]]),\n" + " ['Runtime: ', r.state], ['Started', r.started], ['Active profile', r.active_profile], ['IP', r.ip || 'none'],\n" + " ['AP running', r.ap_running], ['AP clients', r.ap_clients], ['Wi-Fi last error', r.last_error],\n" + " ['mDNS generation', m.generation], ['Hostname', m.hostname + '.local'], ['Expected announcement', m.announced],\n" + " ['mDNS last error', m.last_error], ['DNS verification', 'Not client-verified DNS.']]);\n" " if (!['ap','0','1','2','3'].includes(net('target').value)) net('target').value = 'ap';\n" " renderNetworkTarget(); net('suffix').value = m.suffix; net('edit').hidden = false;\n" " net('detail').textContent = (networkPending ? 'Snapshot may be stale: outcome pending or unknown. ' : 'Working snapshot refreshed (Wi-Fi and mDNS are separate consistent copies). ') + 'Browser drafts are not saved; Save persists device working state.';\n" diff --git a/tests/web_ui_session/browser.cjs b/tests/web_ui_session/browser.cjs index c255dfe..742186b 100644 --- a/tests/web_ui_session/browser.cjs +++ b/tests/web_ui_session/browser.cjs @@ -38,12 +38,22 @@ function browser({onlyLoader = false, withLoader = false, role = 'user', usernam setInterval: (fn, ms) => timeout(fn, ms, true), clearInterval: id => timers.delete(id), requestAnimationFrame: fn => timeout(fn, -1), cancelAnimationFrame: id => timers.delete(id), location: {origin: 'https://sak.local', replace: path => redirects.push(path)}}; - const context = vm.createContext({window, document: {getElementById(id) { - return nodes[id] ||= {textContent: '', value: '', checked: false, dataset: {}, classList: {toggle() {}}, - setAttribute(k, v) { this[k] = v; }, - getBoundingClientRect: () => ({width: 100, height: 100}), - addEventListener(k, fn) { this[k] = fn; }}; - }}, Terminal, FitAddon: {FitAddon: class { + class Element { + constructor(tagName = 'div') { + this.tagName = tagName.toUpperCase(); this.children = []; this._text = ''; + this.value = ''; this.checked = false; this.dataset = {}; this.classList = {toggle() {}}; + } + get textContent() { return this._text + this.children.map(child => child.textContent).join(''); } + set textContent(value) { this.children.forEach(child => { child.parentNode = null; }); this.children = []; this._text = String(value); } + appendChild(child) { this.children.push(child); child.parentNode = this; return child; } + setAttribute(k, v) { this[k] = v; } + getBoundingClientRect() { return {width: 100, height: 100}; } + addEventListener(k, fn) { this[k] = fn; } + } + const context = vm.createContext({window, document: { + createElement: tag => new Element(tag), + getElementById(id) { return nodes[id] ||= new Element(); } + }, Terminal, FitAddon: {FitAddon: class { constructor() { this.measurements = []; this.calls = 0; fits.push(this); } proposeDimensions() { ++this.calls; return this.measurements.length ? this.measurements.shift() : {cols: 80, rows: 24}; } }}, @@ -830,7 +840,8 @@ async function test(name, fn) { await fn(); ++passed; console.log('PASS JS:', na }); const slotKey = index => ({index,type:'ssh-ed25519',fingerprint:'SHA256:' + String.fromCharCode(97 + index).repeat(43)}); function assertKeySlots(b, indices) { - assert.equal(b.nodes['account-keys-list'].textContent, indices.map(index => `${index}: ssh-ed25519 ${slotKey(index).fingerprint}`).join('\n')); + assert.deepEqual(b.nodes['account-keys-list'].children.map(node => [node.tagName, node.textContent]), + indices.flatMap(index => [['DT', `${index}: `], ['DD', `ssh-ed25519 ${slotKey(index).fingerprint}`]])); assert.equal(b.nodes['account-key-index'].value, String(indices[0])); for(let index=0;index<3;++index) { const option=b.nodes['key-option-'+index], present=indices.includes(index); @@ -927,6 +938,20 @@ async function test(name, fn) { await fn(); ++passed; console.log('PASS JS:', na const s=await accountsBrowser(); s.nodes['account-public-key'].value='ssh-ed25519 AAAA'; let warning; s.window.confirm=m=>{warning=m;return true;}; s.queues[accountPath].push(failure(401)); s.click('account-key-add'); await tick(); assert.match(warning,/ALL.*web\/SSH.*401.*NOT proof/); assert.deepEqual(s.redirects,['/login']); assert.ok(s.sockets.every(s=>s.closed)); assert.doesNotMatch(s.nodes['account-operation-detail'].textContent,/completed/); }); + await test('Account definition rows and key rows clear as DOM children and fence late lists', async () => { + const b = await keyBrowser(), list = b.nodes['accounts-list'], keys = b.nodes['account-keys-list']; + assert.deepEqual(list.children.map(n => [n.tagName, n.textContent]), + [['DT', 'alice'], ['DD', 'admin (you)'], ['DT', 'carol'], ['DD', 'user']]); + assert.ok(keys.children.length > 0); + assert.ok([...list.children, ...keys.children].every(n => n.children.length === 0)); + const old = [...list.children, ...keys.children], d = deferred(); + b.queues['/api/settings/accounts'].push(d.promise); b.click('refresh-accounts'); await tick(); + b.click('settings-serial'); await tick(); + assert.equal(list.children.length, 0); assert.equal(keys.children.length, 0); + assert.ok(old.every(n => n.parentNode === null)); + d.resolve(json({users: [{username: 'late', role: 'user', user_id: 9, auth_generation: 1}]})); await tick(); + assert.equal(list.children.length, 0); assert.equal(keys.children.length, 0); + }); await test('Accounts list is admin-only, secret-free schema and navigation preserves both sockets', async () => { const u = await connected(); u.click('settings-accounts'); await tick(); assert.ok(!u.calls.some(c => c.url === '/api/settings/accounts')); diff --git a/tests/web_ui_session/layout.py b/tests/web_ui_session/layout.py new file mode 100644 index 0000000..565dd8f --- /dev/null +++ b/tests/web_ui_session/layout.py @@ -0,0 +1,171 @@ +"""Structural checks of production HTML; not a browser layout/visual test.""" +from html.parser import HTMLParser + + +class Document(HTMLParser): + def __init__(self, html): + super().__init__(convert_charrefs=True) + self.root = {'tag': 'root', 'attrs': {}, 'children': [], 'text': ''} + self.stack = [self.root] + self.ids = {} + self.feed(html) + assert self.stack == [self.root] + + def handle_starttag(self, tag, attrs): + node = {'tag': tag, 'attrs': dict(attrs), 'children': [], 'text': '', 'parent': self.stack[-1]} + self.stack[-1]['children'].append(node) + if 'id' in node['attrs']: + ident = node['attrs']['id'] + assert ident not in self.ids, ident + self.ids[ident] = node + if tag not in {'meta', 'link', 'img', 'input', 'br', 'hr'}: + self.stack.append(node) + + def handle_endtag(self, tag): + assert self.stack[-1]['tag'] == tag, (tag, self.stack[-1]['tag']) + self.stack.pop() + + def handle_data(self, data): + for node in self.stack: + node['text'] += data + + +def check_layout(html): + doc = Document(html) + ids = doc.ids + def classes(node): + return node['attrs'].get('class', '').split() + def descendants(node): + for child in node['children']: + yield child + yield from descendants(child) + def ancestor(node, cls): + while 'parent' in node: + node = node['parent'] + if cls in classes(node): + return node + raise AssertionError(cls) + for ident in ('settings-values', 'accounts-list', 'account-keys-list', 'network-summary'): + assert ids[ident]['tag'] == 'dl' + assert 'settings-values' in classes(ids[ident]) + for ident in ('serial-settings-content', 'account-settings', 'network-settings'): + nodes = list(descendants(ids[ident])) + assert not any(n['tag'] == 'pre' for n in nodes) + assert all('connection-detail' in classes(n) for n in nodes if n['tag'] == 'p') + for n in nodes: + if n['tag'] in ('input', 'select', 'textarea'): + assert n['parent']['tag'] == 'label' + try: + ancestor(n, 'settings-edit') + except AssertionError: + ancestor(n, 'serial-edit') + for ident in ('refresh-settings', 'refresh-accounts', 'network-refresh'): + assert ids[ident]['text'] == 'Refresh' + for ident in ('serial-result', 'account-result', 'network-result'): + assert ids[ident]['text'] == 'Check Operation Result' + for ident in ('network-boot', 'network-enabled', 'account-password-saved'): + assert 'settings-check' in classes(ids[ident]['parent']) + for ident in ('account-public-key', 'account-generated'): + assert 'settings-wide' in classes(ids[ident]['parent']) + assert 'readonly' in ids['account-generated']['attrs'] + assert 'hidden' in ids['account-generated-panel']['attrs'] + assert ids['network-apply']['parent'] is ids['network-wifi-save']['parent'] + assert ids['network-wifi-save']['parent'] is ids['network-wifi-load']['parent'] + assert ids['network-start']['parent'] is not ids['network-wifi-save']['parent'] + assert ids['network-start']['parent'] is ids['network-next-profile']['parent'] + assert html.index('id="account-delete"') < html.index('id="account-result"') < html.index('id="account-key-add"') < html.index('id="account-submit-password"') + css = next(n['text'] for n in descendants(doc.root) if n['tag'] == 'style') + for rule in ( + '.settings-values dd{margin:0;white-space:pre-wrap;overflow-wrap:anywhere}', + '.settings-values{display:grid;grid-template-columns:minmax(110px,1fr) minmax(0,2fr);gap:8px 16px;max-width:600px}', + '.serial-edit,.settings-edit{display:grid;grid-template-columns:repeat(auto-fit,minmax(160px,1fr));gap:12px;max-width:600px}', + '.settings-edit .settings-wide{grid-column:1/-1}', + '.settings-edit input[type=checkbox]{width:auto;flex:none}', + '.settings-edit textarea{min-height:96px;resize:vertical}', + '.settings-edit input[readonly]{font-family:monospace}', + '.settings-page h3{font-size:1.17em;margin:1em 0}', + '.settings-page .connection-detail{max-width:600px;overflow-wrap:anywhere}', + '@media(max-width:360px)', + '.settings-edit{grid-template-columns:minmax(0,1fr)}', + ): + assert rule in css, rule + assert '.settings-edit textarea{font:inherit;width:100%;min-width:0;' in css + print('PASS HTML layout: parsed structure, shared styles, labels, wrapping, checkbox sizing and action order across all three settings views') + + +def check_browser_layout(html, tmp, executable): + """Optional real CSS layout check; fixture data, no application/network execution.""" + import json + import re + import subprocess + # Keep production HTML/CSS, but do not run its authenticated loader or assets. + fixture = re.sub(r'